[tarantool-patches] Re: [PATCH v7 3/7] sql: introduce expr_len for sql_expr_compile

Kirill Shcherbatov kshcherbatov at tarantool.org
Fri May 25 14:54:07 MSK 2018


> 1. Looks like expr_len is the expression that is intended to
> parse a length.
> Do you mean this?: "Length of @an expr."

- * @param expr_len Expression to parse length.
+ * @param expr_len Length of @an expr..

> 2. Bad indentation.
 int
sql_expr_compile(struct sqlite3 *db, const char *expr, int expr_len,
- struct Expr **result);
+ struct Expr **result);





More information about the Tarantool-patches mailing list