[PATCH 3/8] memtx: pass engine to memory allocation functions

Konstantin Osipov kostja at tarantool.org
Tue May 22 16:47:28 MSK 2018


* Vladimir Davydov <vdavydov.dev at gmail.com> [18/05/22 15:10]:
> We need this so that we can force garbage collection when we are short
> on memory. There are two such functions: one is used for allocating
> index extents, another for allocating tuples. Index allocating function
> has an opaque context so we simply reuse it for passing memtx engine to
> it. To pass memtx engine to tuple allocating function, we add an opaque
> engine specific pointer to tuple_format (engine_data) and set it to
> memtx_engine for memtx spaces.

Please rename engine_data to engine. I would not use an opaque
pointer either, reference the engine explicitly.

Otherwise OK to push.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov



More information about the Tarantool-patches mailing list