[tarantool-patches] Re: [PATCH v6 0/4] sql: moved Checks to server

[Vladislav Shpilevoy]

Hello. Thanks for the patchset! Please, describe what it does, why and how.

On 15/05/2018 20:03, Kirill Shcherbatov wrote:
> Branch: http://github.com/tarantool/tarantool/tree/gh-3272-no-sql-checks
> Issue: https://github.com/tarantool/tarantool/issues/3272
> 
> Kirill Shcherbatov (4):
>    sql: fix code style in sqlite3Pragma
>    sql: remove SQL fields from Table and Column
>    sql: space_def* instead of Table* in Expr
>    sql: remove Checks to server
> 
>   src/box/alter.cc            |  11 +
>   src/box/field_def.c         |   1 +
>   src/box/field_def.h         |  20 ++
>   src/box/key_def.cc          |   2 +-
>   src/box/opt_def.c           |  16 +-
>   src/box/opt_def.h           |   8 +-
>   src/box/space_def.c         | 135 +++++++++--
>   src/box/space_def.h         |  24 ++
>   src/box/sql.c               | 225 +++++++++++++++---
>   src/box/sql.h               | 125 +++++++++-
>   src/box/sql/alter.c         |  59 +++--
>   src/box/sql/analyze.c       |  18 +-
>   src/box/sql/build.c         | 553 +++++++++++++++++++++++---------------------
>   src/box/sql/delete.c        |  31 +--
>   src/box/sql/expr.c          | 215 ++++++++---------
>   src/box/sql/fkey.c          |  71 +++---
>   src/box/sql/hash.c          |  10 +-
>   src/box/sql/hash.h          |   2 +-
>   src/box/sql/insert.c        | 138 ++++++-----
>   src/box/sql/parse.y         |  86 +++----
>   src/box/sql/pragma.c        |  96 ++++----
>   src/box/sql/pragma.h        |   2 -
>   src/box/sql/prepare.c       |  52 +++--
>   src/box/sql/resolve.c       |  71 +++---
>   src/box/sql/select.c        | 245 ++++++++++++--------
>   src/box/sql/sqliteInt.h     |  81 ++-----
>   src/box/sql/tokenize.c      |  12 +-
>   src/box/sql/treeview.c      |   2 +-
>   src/box/sql/trigger.c       |  20 +-
>   src/box/sql/update.c        |  60 ++---
>   src/box/sql/util.c          |   9 -
>   src/box/sql/vdbe.c          |  28 +--
>   src/box/sql/vdbeaux.c       |  34 ---
>   src/box/sql/vdbemem.c       |  18 +-
>   src/box/sql/where.c         |  27 ++-
>   src/box/sql/wherecode.c     |  53 +++--
>   src/box/sql/whereexpr.c     |  19 +-
>   test/sql-tap/check.test.lua |  13 +-
>   38 files changed, 1540 insertions(+), 1052 deletions(-)
>