[tarantool-patches] [PATCH v7 0/7] sql: remove Checks to server

Kirill Shcherbatov kshcherbatov at tarantool.org
Wed May 23 17:05:27 MSK 2018


Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3272-no-sql-checks
Issue: https://github.com/tarantool/tarantool/issues/3272

As we need to store Checks array in opt_def MsgPack in future
introduced special type and decode callback to_array used in opt_set
function.
Removed SELECTTRACE_ENABLED macro with conditional fields from
struct Parse to prevent different object sizes across the project.
New server checks stored in space_opts. For ExprList transfering
to server data is packed in msgpack as array of maps:
[{"expr_str": "x < y", "name" : "FIRST"}, ..]
Introduced checks_array_decode aimed to unpack this
complex package.
Introduced sql_checks_update_space_def_reference to update space
references as space_def pointer changes over the time,
i.e. resolved checks refer released memory.

Kirill Shcherbatov (7):
  sql: remove parser construct, destruct to sql.h
  box: introduce OPT_ARRAY opt_type to decode arrays
  sql: introduce expr_len for sql_expr_compile
  sql: rename sql_expr_free to sql_expr_delete
  sql: change sqlite3AddCheckConstraint signature
  sql: export funcs defined on Expr, ExprList to sql.h
  sql: remove Checks to server

 src/box/alter.cc            |   6 +++
 src/box/opt_def.c           |   9 ++++
 src/box/opt_def.h           |  20 +++++--
 src/box/space_def.c         | 100 ++++++++++++++++++++++++++++++++++-
 src/box/space_def.h         |  12 ++---
 src/box/sql.c               | 107 +++++++++++++++++++++++++++++++++++++-
 src/box/sql.h               | 123 ++++++++++++++++++++++++++++++++++++++++++-
 src/box/sql/build.c         | 124 ++++++++++++++++++++++++++------------------
 src/box/sql/delete.c        |   2 +-
 src/box/sql/expr.c          | 117 +++++++++++++++++++----------------------
 src/box/sql/fkey.c          |  21 ++++----
 src/box/sql/insert.c        |  35 +++++++------
 src/box/sql/parse.y         | 107 +++++++++++++++++++-------------------
 src/box/sql/pragma.h        |   2 -
 src/box/sql/prepare.c       |  11 +++-
 src/box/sql/resolve.c       |  51 +++++++-----------
 src/box/sql/select.c        |  58 +++++++++++----------
 src/box/sql/sqliteInt.h     |  39 +++-----------
 src/box/sql/tokenize.c      |   7 +--
 src/box/sql/trigger.c       |  20 +++----
 src/box/sql/update.c        |   4 +-
 src/box/sql/wherecode.c     |  14 ++---
 src/box/sql/whereexpr.c     |  12 ++---
 test/sql-tap/check.test.lua |  10 ++--
 24 files changed, 674 insertions(+), 337 deletions(-)

-- 
2.7.4





More information about the Tarantool-patches mailing list