[tarantool-patches] Re: [PATCH 4/4] sql: fix SAVEPOINT RELEASE statement

[Vladislav Shpilevoy]

Hello. Thanks for contributing!

See below 2 comments.

1. Lets do not create a new test file on each issue.

On 03/05/2018 21:49, Nikita Pettik wrote:
> Before this patch SAVEPOINT RELEASE statement always raised error,
> due to SQLite's obsolete code. Now it has been removed, and
> SAVEPOINT RELEASE works as desired.
> 
> Closes #3379
> ---
>   src/box/sql/vdbe.c                           |  7 -----
>   test/sql/gh-3379-release-savepoints.result   | 40 ++++++++++++++++++++++++++++
>   test/sql/gh-3379-release-savepoints.test.lua | 26 ++++++++++++++++++
>   3 files changed, 66 insertions(+), 7 deletions(-)
>   create mode 100644 test/sql/gh-3379-release-savepoints.result
>   create mode 100644 test/sql/gh-3379-release-savepoints.test.lua
> 
> diff --git a/test/sql/gh-3379-release-savepoints.result b/test/sql/gh-3379-release-savepoints.result
> new file mode 100644
> index 000000000..5f5804b66
> --- /dev/null
> +++ b/test/sql/gh-3379-release-savepoints.result
> @@ -0,0 +1,40 @@
> +test_run = require('test_run').new()
> +---
> +...
> +test_run:cmd("setopt delimiter ';'")
> +---
> +- true
> +...
> +-- These tests check that release of SQL savepoints works as desired.
> +--
> +-- box.cfg()

2. Garbage diff.