[tarantool-patches] Re: [PATCH] sql: remove temporary box_iterator_key_def

Kirill Yukhin kyukhin at tarantool.org
Thu May 17 19:03:51 MSK 2018


Hello Vlad,
On 17 мая 18:05, Vladislav Shpilevoy wrote:
> Hello. Thanks for the patch!
> 
> On 17/05/2018 16:41, Kirill Yukhin wrote:
> > It is possible to extract key_def from iterator directly
> > in SQL FE. So, no need in any temporary API hacks anymore.
> > The patch removes this API function and replaces its calls
> > w/ direct field access in SQL FE.
> > 
> > Closes #2425
> > ---
> 
> 1. Please, post branch and issue links here.
Branch: https://github.com/tarantool/tarantool/tree/kyukhin/gh-2425-remove-box_iterator_key_def
Issue: https://github.com/tarantool/tarantool/issues/2425
 
> 2. I can not find any branch with 2425 in name.
I forgot to push it to GH. Done.

> The patch LGTM.
I'll commit it to 2.0 branch, thanks!

--
Regards, Kirill Yukhin




More information about the Tarantool-patches mailing list