[tarantool-patches] Re: [PATCH v1 1/1] sql: Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE

[n.pettik]

Don’t hurry when preparing patch or making fixes.
Remember: ‘haste makes waste’.

>> Please, read guidelines carefully.
>> 
>>> sql: Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE
>> 
>> According to our docs:
>> — 2. Try to limit the subject line to 50 characters or so.
>> — 3. Start the subject line with a capital letter unless it prefixed with a subsystem name and semicolon…
> Sorry. I fixed that.

No, you didn’t. Read it again. I see old violations on your branch.

>There is exeptions, when these clauses are used.

Typo: ’there are’. Use some spell-checker or whatever.
Rephrase whole sentence: it seems to be misleading.

>> I would also add tests (or just rewrite yours) which check that complete CREATE TABLE statement doesn’t support TEMP clause:
>> 
>> CREATE TEMP TABLE t1(…);
>> 
>> CREATE TEMPORARY TABLE t1(…);
> +		CREATE TEMP TABLE t1();
> +		CREATE TEMPORARY TABLE t1();


Cmon, use complete form of CREATE TABLE statement.
You can’t create table with no columns.