[tarantool-patches] Re: [PATCH 0/4] Rework SQL transaction processing

[Kirill Yukhin]

Hello Nikita, Vlad,
On 07 мая 16:31, Vladislav Shpilevoy wrote:
> Hello. Thanks for review fixes! The whole patchset LGTM now.
> 
> On 03/05/2018 21:49, Nikita Pettik wrote:
> > Branch: https://github.com/tarantool/tarantool/tree/np/rework-sql-transactions
> > Issue:
> > https://github.com/tarantool/tarantool/issues/3237
> > https://github.com/tarantool/tarantool/issues/3313
> > https://github.com/tarantool/tarantool/issues/3379
The patch set fails testing:
[026] sql/transitive-transactions.test.lua                            [ fail ]
[026]
[026] Test failed! Result content mismatch:
[033] sql/drop-table.test.lua                                         [ pass ]
[026] --- sql/transitive-transactions.result    Fri May 11 10:15:28 2018
[026] +++ sql/transitive-transactions.reject    Fri May 11 10:15:53 2018
[026] @@ -107,19 +107,20 @@
[026]  box.sql.execute('PRAGMA defer_foreign_keys = 1;')
[026]  fk_defer();
[026]  ---
[026] +- error: 'Operation is not permitted when there is an active transaction '
[026]  ...
[026]  box.space.CHILD:select();
[026]  ---
[026] -- - [1, 2]
[026] +- []
[026]  ...

--
Regards, Kirill Yukhin