[tarantool-patches] Re: [PATCH v7 5/7] sql: change sqlite3AddCheckConstraint signature

Kirill Shcherbatov kshcherbatov at tarantool.org
Wed May 30 11:32:06 MSK 2018


> Lets use ‘struct’ prefix, as it should be according to codestyle.
> The same.
diff --git a/src/box/sql/build.c b/src/box/sql/build.c
index 50e4985..db8e0ce 100644
--- a/src/box/sql/build.c
+++ b/src/box/sql/build.c
@@ -1020,10 +1020,10 @@ sqlite3AddPrimaryKey(Parse * pParse,    /* Parsing context */
 }
 
 void
-sql_add_check_constraint(Parse *parser, ExprSpan *span)
+sql_add_check_constraint(struct Parse *parser, struct ExprSpan *span)
 {
        struct Expr *expr = span->pExpr;
-       Table *table = parser->pNewTable;
+       struct Table *table = parser->pNewTable;
        if (table != NULL) {
                table->pCheck =
                        sqlite3ExprListAppend(parser, table->pCheck, expr);

>> + * Add a new CHECK constraint to the table currently under construction.
> 
> Out of 66 chars.
diff --git a/src/box/sql/sqliteInt.h b/src/box/sql/sqliteInt.h
index 10732aa..87ebbfb 100644
--- a/src/box/sql/sqliteInt.h
+++ b/src/box/sql/sqliteInt.h
@@ -3506,7 +3506,8 @@ void sqlite3AddNotNull(Parse *, int);
void sqlite3AddPrimaryKey(Parse *, ExprList *, int, int, enum sort_order);

/**
- * Add a new CHECK constraint to the table currently under construction.
+ * Add a new CHECK constraint to the table currently under
+ * construction.
* @param parser Parsing context.
* @param span Expression span object.
*/





More information about the Tarantool-patches mailing list