[tarantool-patches] Re: [PATCH v2 2/5] Move struct on_access_denied_ctx into error.h

Alexander Turenko alexander.turenko at tarantool.org
Fri May 4 14:06:21 MSK 2018


Hi, Vlad!

One tiny comment here.

WBR, Alexander Turenko.

On Sun, Apr 29, 2018 at 01:45:10AM +0300, Vladislav Shpilevoy wrote:
> The issue #3290 was not only about upper/lower Lua functions, but
> about unicode comparison functions too. Actually, the issue
> requests upper/lower exactly to do string comparison, that can be
> done more quick with no garbage strings creation. For this
> Tarantool collations can be used.
> 
> To be able to expose collations into Lua, the coll.h/.c,
> coll_def.h/.c and coll_cache.h/.c must be moved from 'box' static
> library into 'core' static library so that they will be built
> together with string utils. But they require 'stat' and
> 'box_error' libraries. The patch prepares the files going to be
> moved, so in the next patch they are just moved, with no changes.
> It saves commit history.

'together with string utils' -- no more relevant to the patchset part
above this commit?




More information about the Tarantool-patches mailing list