[tarantool-patches] Re: [PATCH v1 1/1] Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE

[roman.habibov1 at yandex.ru]

diff --git a/commits/1 b/commits/1
index 27ef2f6..dee20d6 100644

@@ -5,7 +5,7 @@ Date: Sat, 5 May 2018 01:45:06 +0300
 Subject: [PATCH v1 1/1] sql: tests for CREATE TEMP TABLE and  CREATE TEMPORARY
  TABLE

07.05.2018, 16:08, "Vladislav Shpilevoy" <v.shpilevoy at tarantool.org>:
> 1. Please, in the commit title write a Tarantool submodule prefix. For example,
> your patch is about SQL, so you would write 'sql: ' prefix.

diff --git a/test/sql-tap/table.test.lua b/test/sql-tap/table.test.lua
index 4882b18..21213bc 100755
--- a/test/sql-tap/table.test.lua
+++ b/test/sql-tap/table.test.lua
@@ -611,6 +611,9 @@ test:do_execsql2_test(
 --     SELECT * FROM [t4"abc];
 --   }
 -- } {cnt 1 max(b+c) 5}
+
+-- gh-2166 functions with TEMP and TEMPORARY are removed, tests needed to show that
+
 test:do_catchsql_test(
 	"temp",
 	[[

07.05.2018, 16:08, "Vladislav Shpilevoy" <v.shpilevoy at tarantool.org>:
>2. Before the test cases write in comments what do you test here, and
>:write a link to the issue in the format 'gh-NNNN: description'.