[tarantool-patches] Re: [PATCH 1/2] sql: introduce sort order to key_part/key_part_def

[Vladislav Shpilevoy]

Hello. Thanks for contributing! See 2 comments below.

1. I still can grep SQLITE_SO_ASC/DESC in build.c

On 08/05/2018 10:56, Kirill Yukhin wrote:
> Legacy SQL DD structs contained sort_order, defined per
> index column. During integration, those structs are to be
> vanished. So, introduce new field to part entity of Tarantool.
> This field states for sorting order of given part in give index.
> This field is ignored by Tarantool everywhere excpept for
> some of nested queries in SQL.
> 
> Patch also replaces usages of SQL's stored sort order w/ this new
> field.
> 
> Part of #3235
> ---
>   src/box/key_def.cc      | 28 ++++++++++++++++++++++------
>   src/box/key_def.h       | 16 +++++++++++++++-
>   src/box/schema.cc       | 30 ++++++++++++++++++++----------
>   src/box/sql.c           | 11 +++++++++--
>   src/box/sql/build.c     | 47 ++++++++++++++++++++++++++++++++++++-----------
>   src/box/sql/expr.c      |  9 ++++-----
>   src/box/sql/insert.c    |  3 ++-
>   src/box/sql/parse.y     | 10 +++++-----
>   src/box/sql/pragma.c    |  7 ++++---
>   src/box/sql/select.c    |  2 +-
>   src/box/sql/sqliteInt.h | 20 ++++++++++++--------
>   src/box/sql/vdbe.h      |  1 +
>   src/box/sql/where.c     | 11 ++++++-----
>   src/box/sql/wherecode.c | 10 ++++++----
>   14 files changed, 143 insertions(+), 62 deletions(-)
> 
> diff --git a/src/box/sql/sqliteInt.h b/src/box/sql/sqliteInt.h
> index 8bb45c9..a811932 100644
> --- a/src/box/sql/sqliteInt.h
> +++ b/src/box/sql/sqliteInt.h
> @@ -3540,6 +3534,16 @@ sql_default_coll();
>   bool
>   space_is_view(Table *);
>   
> +/**
> + * Return name of given column collation from index.

2. Irrelevant comment.