[tarantool-patches] Re: [PATCH 1/1] sql: fix out of time auto commit mode detection

[Kirill Yukhin]

Hello Vlad,
On 22 мая 00:46, Vladislav Shpilevoy wrote:
> Hello. Thanks for review!
> 
> On 22/05/2018 00:45, Nikita Pettik wrote:
> >     + * Once per execution time prepare the programm: detect
> > 
> > Nitpicking: 'program'.
> 
> @@ -5352,7 +5352,7 @@ case OP_Init: {          /* jump */
>         assert(pOp->p4.z==0 || strncmp(pOp->p4.z, "-" "- ", 3)==0);
>         assert(pOp==p->aOp);  /* Always instruction 0 */
>         /*
> -        * Once per execution time prepare the programm: detect
> +        * Once per execution time prepare the program: detect
>          * autocommit, create SQL specific transaction things. To
> > 
> > LGTM.

I've checked you patch into 2.0 branch.
In future, could you pls name your branches according to SOP?
Please, see chapter `Submitting a patch` for details.

> > -- 
> > Nikita Pettik

--
Regards, Kirill Yukhin