[tarantool-patches] Re: [PATCH] sql: refactor SQL delete to allow Lua spaces
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Mon May 21 12:47:56 MSK 2018
Hello. Thanks for the fixes!
>
> diff --git a/src/box/sql/build.c b/src/box/sql/build.c
> index df75186..68f81e8 100644
> --- a/src/box/sql/build.c
> +++ b/src/box/sql/build.c
> @@ -2108,107 +2108,97 @@ sqlite3CreateView(Parse * pParse, /* The parsing context */
> }
> #endif /* SQLITE_OMIT_VIEW */
>
> -#if !defined(SQLITE_OMIT_VIEW)
> -/*
> - * The Table structure pTable is really a VIEW. Fill in the names of
> - * the columns of the view in the pTable structure. Return the number
> - * of errors. If an error is seen leave an error message in pParse->zErrMsg.
> - */
> -int
> -sqlite3ViewGetColumnNames(Parse * pParse, Table * pTable)
> +bool
In Tarantool code style we do not return boolean on non-check functions.
0 or -1, please.
The rest of patch is ok.
More information about the Tarantool-patches
mailing list