[tarantool-patches] Re: [PATCH v7 6/7] sql: export funcs defined on Expr, ExprList to sql.h

[Vladislav Shpilevoy]

Thanks for the fixes! See my 3 comments below.

On 25/05/2018 14:53, Kirill Shcherbatov wrote:
>> 1. Please, do not put extra white space after *.
>> 2. Invalid indentation.
>> 3. No pParse.
>> 4. Wrong indentation.
>> 5. Same.
>> 6. Please, consider this diff:

1. Please, do not decontextualize my comments. It is hard
to restore for which code they were intended.

> 
> diff --git a/src/box/sql.h b/src/box/sql.h
> index ec4f298..2a87d14 100644
> --- a/src/box/sql.h
> +++ b/src/box/sql.h
> @@ -190,7 +190,7 @@ sql_table_def_rebuild(struct sqlite3 *db, struct Table *table);
>    * @retval not NULL on success.
>    */
>   struct ExprList *
> -sql_expr_list_dup(struct sqlite3 * db, struct ExprList * p, int flags);
> +sql_expr_list_dup(struct sqlite3 *db, struct ExprList * p, int flags);

> 1. Please, do not put extra white space after *.

2. Still not fixed.

3. Why did you ignore part of comment 7 from the previous review?