[tarantool-patches] [PATCH 3/3] netbox: deprecate console support
Konstantin Osipov
kostja at tarantool.org
Thu Mar 22 22:37:07 MSK 2018
* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [18/03/22 22:18]:
> Print warning about that. After a while the cosole support will
> be deleted from netbox.
> ---
> src/box/lua/net_box.lua | 6 ++++++
> 1 file changed, 6 insertions(+)
This is a no-brainer.
>
> diff --git a/src/box/lua/net_box.lua b/src/box/lua/net_box.lua
> index f3f69f52f..cf1a04237 100644
> --- a/src/box/lua/net_box.lua
> +++ b/src/box/lua/net_box.lua
> @@ -396,7 +396,10 @@ local function create_transport(host, port, user, password, callback,
> if err then
> return error_sm(err, msg)
> end
> + -- @deprecated since 1.10
> if greeting.protocol == 'Lua console' then
> + log.warn("Netbox text protocol support is deprecated since 1.10, "..
> + "please use require('console').connect() instead")
> local setup_delimiter = 'require("console").delimiter("$EOF$")\n'
> method_codec.inject(send_buf, nil, nil, setup_delimiter)
> local err, response = send_and_recv_console()
> @@ -673,7 +676,10 @@ local function do_connect(host, port, opts, existing_connection, greeting)
> end
> end
> end
> + -- @deprecated since 1.10
> if opts.console then
> + log.warn("Netbox console API is deprecated since 1.10, please use "..
> + "require('console').connect() instead")
> setmetatable(remote, console_mt)
> else
> setmetatable(remote, remote_mt)
> --
> 2.14.3 (Apple Git-98)
>
>
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.org - www.twitter.com/kostja_osipov
More information about the Tarantool-patches
mailing list