[tarantool-patches] Re: [PATCH] sql: ban of REINDEX syntax
Alexander Turenko
alexander.turenko at tarantool.org
Wed Mar 21 16:02:24 MSK 2018
LGTM. Thanks!
Nikita, can you please look into this patch?
WBR, Alexander Turenko.
On Wed, Mar 21, 2018 at 02:06:08PM +0300, Ivan Ilyin wrote:
> From: vanyail <vanyail at yandex.ru>
>
> This change cut REINDEX syntax from keywords and also disables tests
> which were using this syntax.
>
> This patch affects only parser, REINDEX implementation still exists,
> because it is planned to be fixed and enabled in the scope of #3195.
>
> Note that REINDEX keyword is still in '%fallback' directive in
> 'parse.y'. The reason described in 'parse.y' in comment related
> to '%fallback'.
>
> Fixes #2174
> ---
>
> branch: https://github.com/tarantool/tarantool/tree/gh-2174-ban-reindex-syntax
> ---
> src/box/sql/parse.c | 1797 +++++++++++-----------
> src/box/sql/parse.y | 22 +-
> test/sql-tap/gh-2174-ban-reindex-syntax.test.lua | 17 +
> test/sql-tap/suite.ini | 4 +
> 4 files changed, 925 insertions(+), 915 deletions(-)
> create mode 100755 test/sql-tap/gh-2174-ban-reindex-syntax.test.lua
>
> ...
More information about the Tarantool-patches
mailing list