[patches] [PATCH] Delete invalid test
Konstantin Osipov
kostja at tarantool.org
Mon Mar 5 10:04:58 MSK 2018
* Georgy Kirichenko <georgy at tarantool.org> [18/03/02 17:12]:
> An error rollback only a current statement but not a whole transaction.
> In this test a transaction rollbacks because of a yield while a test-run
> communication.
>
> Fixes #3145
Please don't delete the test case, but swap rollback() and
select{}: rollback first.
The test case itself is on the same branch as the fix for
multistatement ddl transaction, please push it on a separate
branch.
> ---
> https://github.com/tarantool/tarantool/tree/gh-3145-flacky-test
>
> test/box/errinj.result | 19 -------------------
> test/box/errinj.test.lua | 8 --------
> 2 files changed, 27 deletions(-)
>
> diff --git a/test/box/errinj.result b/test/box/errinj.result
> index 4ef7e887c..85b327504 100644
> --- a/test/box/errinj.result
> +++ b/test/box/errinj.result
> @@ -442,25 +442,6 @@ errinj.set("ERRINJ_TUPLE_ALLOC", false);
> ---
> - ok
> ...
> -box.begin()
> - s:insert{1}
> - errinj.set("ERRINJ_TUPLE_ALLOC", true)
> - s:insert{2}
> -box.commit();
> ----
> -- error: Failed to allocate 18 bytes in slab allocator for memtx_tuple
> -...
> -errinj.set("ERRINJ_TUPLE_ALLOC", false);
> ----
> -- ok
> -...
> -s:select{};
> ----
> -- []
> -...
> -box.rollback();
> ----
> -...
> s:select{};
> ---
> - []
> diff --git a/test/box/errinj.test.lua b/test/box/errinj.test.lua
> index 992f6e2a9..43b5b51a6 100644
> --- a/test/box/errinj.test.lua
> +++ b/test/box/errinj.test.lua
> @@ -117,14 +117,6 @@ box.commit();
> s:select{};
> box.rollback();
> errinj.set("ERRINJ_TUPLE_ALLOC", false);
> -box.begin()
> - s:insert{1}
> - errinj.set("ERRINJ_TUPLE_ALLOC", true)
> - s:insert{2}
> -box.commit();
> -errinj.set("ERRINJ_TUPLE_ALLOC", false);
> -s:select{};
> -box.rollback();
> s:select{};
> box.begin()
> s:insert{1}
> --
> 2.16.2
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.org - www.twitter.com/kostja_osipov
More information about the Tarantool-patches
mailing list