[tarantool-patches] Re: [PATCH 0/4] Cleanup SQL memory and threading subsystems

[v.shpilevoy at tarantool.org]

LGTM.

> 26 марта 2018 г., в 18:56, Kirill Yukhin <kyukhin at tarantool.org> написал(а):
> 
> This patcheset perform a cleanup of SQL frontend by removing
> dead memory allocators and their APIs and by getting rid of
> all mutex-related code.
> 
> Issue: https://github.com/tarantool/tarantool/issues/3192
> Branch: https://github.com/tarantool/tarantool/tree/kyukhin/gh-3192-remove-sqlite3
> 
> 
> Kirill Yukhin (4):
>  sql: Remove all references to sqlite3.h
>  sql: remove mutexes around the code
>  sql: remove dead memory allocation systems
>  sql: Remove dead defines from sqliteInt.h
> 
> src/box/execute.c          |    2 +-
> src/box/lua/sql.c          |    2 +-
> src/box/sql.c              |    2 -
> src/box/sql/CMakeLists.txt |    9 -
> src/box/sql/date.c         |    7 -
> src/box/sql/func.c         |    2 -
> src/box/sql/global.c       |    8 -
> src/box/sql/legacy.c       |    2 -
> src/box/sql/main.c         |  337 +--
> src/box/sql/malloc.c       |  195 +-
> src/box/sql/mem0.c         |  116 -
> src/box/sql/mem1.c         |  314 ---
> src/box/sql/mem2.c         |  602 ----
> src/box/sql/mem3.c         |  767 -----
> src/box/sql/mem5.c         |  648 -----
> src/box/sql/mutex.c        |  211 --
> src/box/sql/mutex.h        |   82 -
> src/box/sql/mutex_noop.c   |  300 --
> src/box/sql/mutex_unix.c   |  442 ---
> src/box/sql/os.c           |   23 +-
> src/box/sql/os_unix.c      |  180 +-
> src/box/sql/parse.c        |  143 +-
> src/box/sql/prepare.c      |    8 -
> src/box/sql/printf.c       |    6 -
> src/box/sql/random.c       |   11 -
> src/box/sql/sqlite3.h      | 6728 --------------------------------------------
> src/box/sql/sqliteInt.h    |  778 ++++-
> src/box/sql/status.c       |   12 +-
> src/box/sql/tokenize.c     |    2 -
> src/box/sql/vdbe.c         |    5 +-
> src/box/sql/vdbeapi.c      |   54 -
> src/box/sql/vdbeaux.c      |    2 -
> src/box/sql/vdbemem.c      |   17 -
> src/box/sql/vdbesort.c     |    6 +-
> 34 files changed, 887 insertions(+), 11136 deletions(-)
> delete mode 100644 src/box/sql/mem0.c
> delete mode 100644 src/box/sql/mem1.c
> delete mode 100644 src/box/sql/mem2.c
> delete mode 100644 src/box/sql/mem3.c
> delete mode 100644 src/box/sql/mem5.c
> delete mode 100644 src/box/sql/mutex.c
> delete mode 100644 src/box/sql/mutex.h
> delete mode 100644 src/box/sql/mutex_noop.c
> delete mode 100644 src/box/sql/mutex_unix.c
> delete mode 100644 src/box/sql/sqlite3.h
> 
> -- 
> 2.11.0
> 
>