[PATCH 1/5] session: forbid creation from Lua binary and applier sessions

v.shpilevoy at tarantool.org v.shpilevoy at tarantool.org
Tue Mar 20 16:46:05 MSK 2018



> 20 марта 2018 г., в 16:20, Vladimir Davydov <vdavydov.dev at gmail.com> написал(а):
> 
> On Mon, Mar 19, 2018 at 04:34:48PM +0300, Vladislav Shpilevoy wrote:
>> Lua has no access to applier or binary sockets, and these session
>> types must be forbidden.
>> 
>> And after #2667 applier, binary, console and background session
>> owners will be incapsulated inside corresponding modules.
> 
> I don't understand why we should explicitly check session type in this
> funciton. After all, it's an internal function, never intended to be
> called directly by the user, so why should we care?

Just to protect from incorrect usage of API, regardless of is it internal or not. If you propose to drop the patch, then I can drop. Have I drop it?




More information about the Tarantool-patches mailing list