[tarantool-patches] Re: [PATCH v2 0/2] Introduce 'view' space option
v.shpilevoy at tarantool.org
v.shpilevoy at tarantool.org
Tue Mar 27 14:35:05 MSK 2018
LGTM.
> 27 марта 2018 г., в 2:03, Nikita Pettik <korablev at tarantool.org> написал(а):
>
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3268-introduce-view
> Issue: https://github.com/tarantool/tarantool/issues/3268
>
> Changelog:
> - Added tests to check that view can't be created via Lua 'create_space'
> function, and to check that view can be created by direct insertion
> to _space.
> - Implemented SQL follow-up patch to remove TF_View flag and to fetch
> 'view' property from SQL.
>
> Nikita Pettik (2):
> Introduce 'view' space option
> sql: use 'view' opts from space
>
> src/box/alter.cc | 7 ++++
> src/box/errcode.h | 3 +-
> src/box/space_def.c | 7 ++++
> src/box/space_def.h | 6 +++
> src/box/sql.c | 9 +++-
> src/box/sql/alter.c | 4 +-
> src/box/sql/build.c | 27 ++++++++----
> src/box/sql/delete.c | 2 +-
> src/box/sql/fkey.c | 3 +-
> src/box/sql/insert.c | 10 +++--
> src/box/sql/parse.c | 4 +-
> src/box/sql/parse.y | 5 +--
> src/box/sql/select.c | 4 +-
> src/box/sql/sqliteInt.h | 5 ++-
> src/box/sql/trigger.c | 4 +-
> src/box/sql/update.c | 2 +-
> src/box/sql/vdbeaux.c | 2 +-
> src/box/sql/where.c | 3 +-
> test/box/misc.result | 1 +
> test/sql/transition.result | 7 ----
> test/sql/transition.test.lua | 4 --
> test/sql/view.result | 98 ++++++++++++++++++++++++++++++++++++++++++++
> test/sql/view.test.lua | 46 +++++++++++++++++++++
> 23 files changed, 220 insertions(+), 43 deletions(-)
> create mode 100644 test/sql/view.result
> create mode 100644 test/sql/view.test.lua
>
> --
> 2.15.1
>
>
More information about the Tarantool-patches
mailing list