Re[2]: [patches] [daemon 1/1] daemon: Introduce feedback daemon

Ilya Markov imarkov at tarantool.org
Sun Mar 11 19:29:16 MSK 2018


>Среда,  7 марта 2018, 20:07 +03:00 от Georgy Kirichenko <georgy at tarantool.org>:
>
>Please see comment bellow
>
>> +            pcall(http.post, self.host, json.encode(feedback), {timeout=1})
>I think you should set corresponding http headers for the post request

What kind of headers? What for?

>> +
>> +    local buf = s:read('\n')
>> +    while not buf:match("version") do
>> +        buf = s:read('\n')
>> +    end
>I want for a little bit improved http server
>It should be enough if headers are parsed and checked against required values 
>and a Content-length value is extracted and used for a payload reading.

I can check length, and parse request headers until empty line is found. Then parse request body.
I suppose, that might be enough for test.

Could you, please, delete lines of patch in review letter which are not related to you comments?
It would be easier for me to find your comments.

-- 
Thank you,
Ilya Markov


More information about the Tarantool-patches mailing list