[tarantool-patches] [PATCH v2 0/3] console: do not use netbox for console text connections

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Wed Mar 28 16:35:47 MSK 2018


Branch: http://github.com/tarantool/tarantool/tree/gh-2677-prepare-console-for-push
Issue: https://github.com/tarantool/tarantool/issues/2677

Netbox console support complicates both netbox and console. Lets
use sockets directly for text protocol. But the problem is that
before a connection is established, the connection protocol is
unknown (binary or text). It can be determined only when a
greeting is read and decoded. After that the socket must be either
wrapped by netbox API for binary connections, or by text console
API for text connections. To be able to do that the new netbox
functions are introduced: establish_connection and wrap.

Netbox.establish_connection allows to connect to a server, read
and decode greeting.

Netbox.wrap creates a netbox state machine around a given socket.

Vladislav Shpilevoy (3):
  netbox: allow to create a netbox connection from existing socket
  console: do not use netbox for console text connections
  netbox: deprecate console support

 src/box/lua/console.lua   | 162 +++++++++++++++++++++++++++++-------
 src/box/lua/net_box.lua   | 204 ++++++++++++++++++++++++++++++++--------------
 test/box/net.box.result   |  91 ++++++++++++++++++++-
 test/box/net.box.test.lua |  41 +++++++++-
 4 files changed, 400 insertions(+), 98 deletions(-)

-- 
2.14.3 (Apple Git-98)





More information about the Tarantool-patches mailing list