[tarantool-patches] Re: Fwd: [patches] [log 2/2] say: Fix log_rotate

[Georgy Kirichenko]

Please sent all messages bounded as a tree.
A cover message should include issue description
See some comment bellow.

On Wednesday, March 28, 2018 11:06:10 AM MSK Ilya Markov wrote:
> -	if (log->type != SAY_LOGGER_FILE) {
> +	if (pm_atomic_load(&log->type) != SAY_LOGGER_FILE)
>  		return 0;
I am not sure you really need to use atomic. What the case you are  trying to 
fix?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20180329/3e7d9958/attachment.sig>