[tarantool-patches] Re: [PATCH v2 1/1] tuple:tomap: only_names option

Vladimir Davydov vdavydov.dev at gmail.com
Wed Mar 28 13:20:52 MSK 2018


Ack, but please in future add more descriptive comments to your patches.
In this particular case it would be nice to have a description of the
new option in the commit log (what it does, an example of usage).

> From 14a62b394bf7b21d6c9549875abce5c71416c0b3 Mon Sep 17 00:00:00 2001
> From: Kirill Shcherbatov <kshcherbatov at tarantool.org>
> Date: Wed, 28 Mar 2018 11:05:19 +0300
> Subject: [PATCH] tuple:tomap: only_names option
> 
> Fixes #3280
> 
>  src/box/lua/tuple.c        | 22 +++++++++++++--
>  test/engine/tuple.result   | 69 ++++++++++++++++++++++++++++++++++++++++++++++
>  test/engine/tuple.test.lua | 21 ++++++++++++++
>  3 files changed, 110 insertions(+), 2 deletions(-)



More information about the Tarantool-patches mailing list