[patches] [PATCH 4/4] vinyl: on space alter update key definitions in indexes

v.shpilevoy at tarantool.org v.shpilevoy at tarantool.org
Mon Mar 12 17:54:26 MSK 2018


> 
>> 
>> Anyway, this isn't enough. Apart from worker threads, there are also
>> reader fibers, which access key_def too. Referencing key_def for them is
>> likely to turn the code into even a bigger mess than it is with this
>> patch...
> 
> I can not find places in a code, where key_def has no 'index->' before it, except workers (write_iterator), mems, ranges and cache. For workers I moved key_def into struct task. For other places I update key_def in commit_alter(). Where key_def is used in Tx fibers instead of different threads via index->key_def, there is no problems.

Oh, I see. Vy_run_iterator has key_def too. I will fix it.




More information about the Tarantool-patches mailing list