[tarantool-patches] Re: [PATCH v2 1/1] netbox: show is_nullable and collation fields

[v.shpilevoy at tarantool.org]

See below 2 minor comments.

> 26 марта 2018 г., в 20:20, Kirill Shcherbatov <kshcherbatov at tarantool.org> написал(а):
> 
> Fixes #3256
> ---
> 
> Issue: https://github.com/tarantool/tarantool/issues/3256
> Branch: https://github.com/tarantool/tarantool/compare/gh-3256-net-box-nullable-collation-options-output
> 
> src/box/lua/net_box.lua   |  6 ++++-
> test/box/net.box.result   | 65 +++++++++++++++++++++++++++++++++++++++++++++++
> test/box/net.box.test.lua | 24 +++++++++++++++++
> 3 files changed, 94 insertions(+), 1 deletion(-)
> 
> diff --git a/test/box/net.box.test.lua b/test/box/net.box.test.lua
> index c7541ed..fe45721 100644
> --- a/test/box/net.box.test.lua
> +++ b/test/box/net.box.test.lua
> @@ -798,3 +798,27 @@ c.space.test.index.test_index ~= nil
> box.schema.user.revoke('guest','read,write,execute','universe')
> 
> space:drop()
> +
> +

1. Please, do not put multiple empty lines, when it is not necessary.

> +--
> +-- gh-3256 net.box is_nullable and collation options output
> +--
> +
> +space = box.schema.create_space('test')
> +box.schema.user.grant('guest','read,write,execute','space', 'test')
> +pk = space:create_index('pk')
> +sk = space:create_index('sk', {parts = {{2, 'unsigned', is_nullable = true}}})
> +c = net:connect(box.cfg.listen)
> +c.space.test.index.sk.parts
> +c:close()
> +space:drop()
> +
> +space = box.schema.create_space('test')
> +box.schema.user.grant('guest','read,write,execute','space', 'test')
> +box.internal.collation.create('test', 'ICU', 'ru-RU')
> +sk = space:create_index('sk', { type = 'tree', parts = {{1, 'str', collation = 'test'}}, unique = true })
> +c = net:connect(box.cfg.listen)
> +c.space.test.index.sk.parts
> +c:close()
> +box.internal.collation.drop('test')
> +space:drop()
> \ No newline at end of file

2. Please, add an empty line at the end of the file.

> -- 
> 2.7.4
>