[tarantool-patches] Re: [PATCH v4 6/6] sql: VDBE tests for trigger existence

[n.pettik]

I have noticed, that in DEBUG mode there are a lot of compile errors:

/Users/n.pettik/tarantool/src/box/sql/trigger.c:102:6: error: variable 'trigger_name' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
        if (sqlite3FixSrcList(&fixdb, table) != 0)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/n.pettik/tarantool/src/box/sql/trigger.c:156:20: note: uninitialized use occurs here
        sqlite3DbFree(db, trigger_name);
                          ^~~~~~~~~~~~
/Users/n.pettik/tarantool/src/box/sql/trigger.c:102:2: note: remove the 'if' if its condition is always false
        if (sqlite3FixSrcList(&fixdb, table) != 0)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/n.pettik/tarantool/src/box/sql/trigger.c:98:6: error: variable 'trigger_name' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
        if (db->mallocFailed)
            ^~~~~~~~~~~~~~~~
/Users/n.pettik/tarantool/src/box/sql/trigger.c:156:20: note: uninitialized use occurs here
        sqlite3DbFree(db, trigger_name);
                          ^~~~~~~~~~~~
/Users/n.pettik/tarantool/src/box/sql/trigger.c:98:2: note: remove the 'if' if its condition is always false
        if (db->mallocFailed)
        ^~~~~~~~~~~~~~~~~~~~~
/Users/n.pettik/tarantool/src/box/sql/trigger.c:91:6: error: variable 'trigger_name' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
        if (table == NULL || db->mallocFailed)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/n.pettik/tarantool/src/box/sql/trigger.c:156:20: note: uninitialized use occurs here
        sqlite3DbFree(db, trigger_name);
                          ^~~~~~~~~~~~
/Users/n.pettik/tarantool/src/box/sql/trigger.c:91:2: note: remove the 'if' if its condition is always false
        if (table == NULL || db->mallocFailed)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/n.pettik/tarantool/src/box/sql/trigger.c:91:6: error: variable 'trigger_name' is used uninitialized whenever '||' condition is true [-Werror,-Wsometimes-uninitialized]
        if (table == NULL || db->mallocFailed)
            ^~~~~~~~~~~~~
/Users/n.pettik/tarantool/src/box/sql/trigger.c:156:20: note: uninitialized use occurs here
        sqlite3DbFree(db, trigger_name);
                          ^~~~~~~~~~~~
/Users/n.pettik/tarantool/src/box/sql/trigger.c:91:6: note: remove the '||' if its condition is always false
        if (table == NULL || db->mallocFailed)
            ^~~~~~~~~~~~~~~~
/Users/n.pettik/tarantool/src/box/sql/trigger.c:105:2: note: variable 'trigger_name' is declared here
        char *trigger_name = sqlite3NameFromToken(db, name);
        ^
4 errors generated.

They are not shown as errors (but displayed as warnings) in Travis,
since in RELEASE mode -Werror is not set.