[tarantool-patches] Re: [PATCH v3 00/10] sql: remove Triggers to server
n.pettik
korablev at tarantool.org
Thu Jun 28 18:47:57 MSK 2018
LGTM as well. But patchset has exposed with two commits:
first one simply consists of refactoring of functions in sql/trigger.c,
renaming struct Trigger to struct sql_trigger and removing SQLITE_OMIT_TRIGGER
define guard. Second one removes global hash for triggers.
IDK what our review policy says: should you look at them or not?
> Now the patchset LGTM.
>
> Nikita, please, review.
More information about the Tarantool-patches
mailing list