[tarantool-patches] Re: [PATCH v2 05/11] box: port schema_find_id to C

[Kirill Shcherbatov]

> 1. You should not apply my diff as is with no inspection. Usually
> I do draft fixes in review. Here is the bug - on return -1
> the iterator and region leaks. This time apply this:
-                       return -1;
+                       rc = -1;

> 2. Same as on the previous review: this function searches not only
> space id, but a system object id.
 /**
- * Find space id by name in specified system space with index.
+ * Find object id by name in specified system space with index.
*
- * @param system_space_id identifier of the system space.
+ * @param system_space_id identifier of the system object.
* @param index_id identifier of the index to lookup.
* @param name of object to lookup.
* @param len length of a name.

> 3. Invalid alignment@@ -115,8 +115,8 @@ sequence_by_id(uint32_t id);
  * @retval -1 on error.
  */
 int
-schema_find_id(uint32_t system_space_id, uint32_t index_id,
-               const char *name, uint32_t len, uint32_t *object_id);
+schema_find_id(uint32_t system_space_id, uint32_t index_id, const char *name,
+              uint32_t len, uint32_t *object_id);