[tarantool-patches] Re: [PATCH][vshard] Reload reloadable fiber
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Wed Jun 27 14:53:57 MSK 2018
On 27/06/2018 14:45, Alex Khatskevich wrote:
> I have rebased and pushed, but...
>
> Non of the tests fails.
>
> As far as I know, there is a couple of blinking tests in vshard.
VShard now has no unstable tests. I got error on your new test, and
even with no rebase it appears sometimes:
======================================================================================
WORKR TEST PARAMS RESULT
---------------------------------------------------------------------------------
[001] unit/util.test.lua [ fail ]
[001]
[001] Test failed! Result content mismatch:
[001] --- unit/util.result Wed Jun 27 14:46:34 2018
[001] +++ unit/util.reject Wed Jun 27 14:52:17 2018
[001] @@ -39,11 +39,11 @@
[001] ...
[001] test_run:grep_log('default', 'Worker_name: reloadable function reloadable_function has been changed')
[001] ---
[001] -- 'Worker_name: reloadable function reloadable_function has been changed'
[001] +- null
[001] ...
[001] test_run:grep_log('default', 'Worker_name is reloaded, restarting')
[001] ---
[001] -- Worker_name is reloaded, restarting
[001] +- null
[001] ...
[001] test_run:grep_log('default', 'Worker_name has been started')
[001] ---
[001]
I think it is because you cancel fiber too early in the test. Please, repair.
>
>
> On 27.06.2018 14:34, Vladislav Shpilevoy wrote:
>> Please, rebase on the latest master branch. When I do,
>> the tests fail.
More information about the Tarantool-patches
mailing list