[tarantool-patches] Re: [PATCH v3 02/10] sql: fix leak on CREATE TABLE and resolve self ref

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Fri Jun 15 12:25:04 MSK 2018


Thanks for the review!

I have fixed it and pushed into 2.0.

On 15/06/2018 01:46, n.pettik wrote:
> Nitpicking: if you can’t fit commit subject into 50 chars,
> you are able to shrink it and instead write about it in commit message.
> Like:
> 
> sql: fix memory leaks
> 
> This patch fixes several memory leaks. One of them appeared during
> introducing space_def in struct Table. Name of table wasn’t released
> in case of successful returning from function sqlite3StartTable().
> Second one - bla-bla-bla.
> 
> It is only advise, tho. But I stick to the point that describing provided changes
> aren’t less important then code itself.
> 
> Patch itself looks OK to me.
> 




More information about the Tarantool-patches mailing list