[tarantool-patches] Re: [PATCH] sql: export `sql_current_time` && enable tests

[Alex Khatskevich]

On 26.06.2018 19:21, n.pettik wrote:
>> -- Test cases table-14.*
>> --
>> @@ -970,26 +944,6 @@ end
>> -- But DROP TABLE is still prohibited because we do not want to
>> -- delete a table out from under a running query.
>> --
>> --- db eval {
>> ---   pragma vdbe_trace = 0;
>> --- }
>> --- Try to create a table from within a callback:
>> --- ["unset","-nocomplain","result"]
>> -test:do_test(
>> -    "table-14.1",
>> -    function()
>> -        local rc = pcall(function()
>> -            test:execsql("SELECT * FROM tablet8 LIMIT 1")
>> -            test:execsql("CREATE TABLE t9(a primary key, b, c)")
>> -            end)
>> -        rc = rc == true and 0 or 1
>> -        return { rc }
>> -    end, {
>> -        -- <table-14.1>
>> -        0
>> -        -- </table-14.1>
>> -    })
>> -
> Idk why did you delete this test within current patch?
>
> The rest seems to be OK.
>
As far as I remember, test was testing ddl inside of a running 
transaction in SQLite with the help of
special TCL api.
However, those lines do not test anything at all and there is a 14.2 
test which does test this case.

1. I have added this text to the commit message.
2. I have rebased this branch on top of 2.0