[PATCH 3/6] iproto: fix IPROTO_SERVER_IS_RO key code

Konstantin Osipov kostja at tarantool.org
Wed Jun 27 20:48:58 MSK 2018


* Vladimir Davydov <vdavydov.dev at gmail.com> [18/06/13 20:40]:
> IPROTO_SERVER_IS_RO currently has code 0x07 and is defined in the header
> key section, which is wrong, because this key is only used in request
> body. Let's move it to the body section, where it belongs, and set its
> code to 0x29. This shouldn't break anything even if 0x07 is reused in
> future, because the two codes belong to different sections and hence are
> never parsed in the same function. Worst that can happen is we fail to
> bootstrap a node in the cluster if it is running a newer tarantool
> version.

Ugh, this is going to break things and we may have to revert, I
pushed to see how it goes.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov



More information about the Tarantool-patches mailing list