[tarantool-patches] Re: [PATCH v3 10/10] sql: VDBE tests for trigger existence
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Wed Jun 20 11:10:36 MSK 2018
Hello. Thanks for the fixes!
Now the same comment as a pair reviews before:
parameter name mismatch in header and source.
On 20/06/2018 09:38, Kirill Shcherbatov wrote:
>> As I told you verbally, here you can use directly diag_set since
>> you know the concrete error code and parameters.
>>
>> So please, apply this diff:
>>
>> @@ -3003,10 +3003,8 @@ case OP_CheckViewReferences: {
>> struct space *space = space_by_id(space_id);
>> assert(space != NULL);
>> if (space->def->view_ref_count > 0) {
>> - box_error_set(__FILE__, __LINE__, ER_DROP_SPACE,
>> - tnt_errcode_desc(ER_DROP_SPACE),
>> - space->def->name,
>> - "other views depend on this space");
>> + diag_set(ClientError, ER_DROP_SPACE, space->def->name,
>> + "other views depend on this space");
>> rc = SQL_TARANTOOL_ERROR;
>> goto abort_due_to_error;
>> }
>>
>>> rc = SQL_TARANTOOL_ERROR;
>>> goto abort_due_to_error;
>>> }
>>
> Thank you for review. Applied.
>
More information about the Tarantool-patches
mailing list