[PATCH 4/6] txn: do not require space id for nop requests

[Konstantin Osipov]

* Vladimir Davydov <vdavydov.dev at gmail.com> [18/06/28 13:39]:
> On Thu, Jun 28, 2018 at 01:23:22PM +0300, Konstantin Osipov wrote:
> > * Vladimir Davydov <vdavydov.dev at gmail.com> [18/06/28 12:14]:
> > > But txn_commit_nop() lives in txn.c. That's why I called it like that.
> > 
> > Let's move it then.
> 
> That's going to look weird, because this function depends on internal
> txn stuff. IMHO it all looks consistent as it is:
> 
>   txn_begin_stmt - prepare DML request in transaction
>   txn_commit_stmt - commit DML request statement
> 
>   txn_commit_nop - commit NOP request statement.
> 
> No?

I see no reason why it should depend on it. Ideally you should be
able to simply call txn_begin_stmt()/txn_commit_stmt(), and that's
it. 

What's the problem?

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov