[RFC PATCH 06/12] box: refactor hot standby recovery

Konstantin Osipov kostja at tarantool.org
Fri Jun 8 16:15:24 MSK 2018


* Vladimir Davydov <vdavydov.dev at gmail.com> [18/06/08 11:28]:
> No, it doesn't. See, even though it removes recover_remaining_wals()
> from recovery_finalize(), it makes hot_standby_f() call it before
> returning, so that we will rescan the xlog dir just before leaving
> hot standby mode:

This is quite tricky. And I don't see why you need to do it this
way - why not add recover_remaining_wals to box_init instead,
where it will be more visible.

> > @@ -490,6 +486,7 @@ hot_standby_f(va_list ap)
> >  
> >  		subscription.events = 0;
> >  	}
> > +	recover_remaining_wals(r, stream, NULL, true);
> >  	return 0;
> >  }

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov



More information about the Tarantool-patches mailing list