[tarantool-patches] Re: [PATCH v3 3/4] session: introduce binary box.session.push

[Konstantin Osipov]

* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [18/06/07 23:59]:

> > My code review for this patch is on branch
> > box-session-push-kostja.
> > 
> > What still needs to be done:
> > 
> > - convert push.test to box-tap
> 
> I have removed assertions and left the test be output checking.
> Push test does many table members checking, and it is simpler to
> just output the tables.
> 
> Assertions were in a single place were a table contains 400 members.
> But ok, now I did it like in vinyl/select_consistency test.
> 
> > - think about alternatives which would preserve sync in a Lua
> >    routine. Looks like using an upvalue would do
> >    https://www.lua.org/pil/27.3.3.html
> 
> I had investigated it before you have recommended and before I
> started the patch. But ok, I have investigated it again, and
> wrote the simple patch, that shows upvalues to be unusable as
> sync storage. See the diff below and the explanation under the diff.

Vlad, I need to push the patch first and investigate this problem
second. I understand somebody wanted to not bother with the sync
in the ticket, but it is not a priority for me. 

Please revert fiber_sync() changes asap and update the tests, so
that I can push the patch. We can talk about fixing
box.session.sync() later. My problem with the patch is that you
make a partial fix (box.session.sync() is still broken) and use
fiber local storage for something that has little to do with a
fiber.

I'm sure there are acceptable ways to fix box.session.sync(). 
I'll be happy to discuss them once we've done with the current
patch.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov