[tarantool-patches] Re: [PATCH v2] sql: fix decode analyze sample

[Alex Khatskevich]

> As far as I understand, there is only one call of sql_stat4_column().
> You may make this function static and move to where.c,
> if you want so.
Ok.
Let it be here by now.
> +    /* Typecast byte array. */
> I guess, it is obsolete comment.
Deleted
>> +    int col_cnt = mp_decode_array(&a);
> mp_decode_array returns uint32_t, so lets use this type.
Fixed
>> +        if (mem == NULL) {
>> +            diag_set(OutOfMemory, sizeof(Mem), "sqlite3ValueNew”,
> sizeof(struct Mem) or *mem
Fixed
> The rest seems OK to me.