[tarantool-patches] Re: [PATCH v1 1/1] sql: drop useless legacy Cursor hints
n.pettik
korablev at tarantool.org
Tue Jun 19 21:31:20 MSK 2018
> On 19 Jun 2018, at 17:31, Kirill Shcherbatov <kshcherbatov at tarantool.org> wrote:
>
>> Could you please resend fresh diff after fixes, so that I review
>> updated version.
>>
>
> Deleted BTREE_BULKLOAD and OPFLAG_BULKCSR as there become
Typo: there —> they.
> useless since btree.c was dropped as a part of #2419.
> Removed SQLITE_ENABLE_CURSOR_HINTS sections as this code
> has never been in use.
> Start use OPFLAG_SEEKEQ instead of equal BTREE_SEEK_EQ as
> this macro name has no sense since no btree present in SQL.
>
> Resolves #3121.
Except for your removals, I also suggest you to remove:
SQLITE_CursorHints macros;
sqlite3CursorHintFlags() function — it is used only once and can be inlined;
sqlite3CursorHasHint() function — it is used only once and can be inlined;
More information about the Tarantool-patches
mailing list