[tarantool-patches] Re: [PATCH 2/3] sql: remove expressions from SQL indexes

[Vladislav Shpilevoy]

Thanks for the patch! See 2 comments below.

On 01/06/2018 18:16, Kirill Yukhin wrote:
> Legacy SQL FE was able to create indexes w/ expressions.
> Tarantool will employ diofferenct scheme to implement

1. diofferenct?

> functional indexes, thus code  handling it in SQL FE is
> dead and redundant. Remove it.
> 
> Part of #3235

2. I pushed my review fixes. Please, consider them as squash if ok.

> ---
>   src/box/sql/build.c     | 22 ++++++---------
>   src/box/sql/delete.c    |  3 +--
>   src/box/sql/expr.c      | 12 ++-------
>   src/box/sql/insert.c    | 72 +++++++++++++++----------------------------------
>   src/box/sql/sqliteInt.h |  6 -----
>   src/box/sql/where.c     | 27 ++-----------------
>   src/box/sql/wherecode.c | 13 +++------
>   src/box/sql/whereexpr.c | 36 +++----------------------
>   8 files changed, 42 insertions(+), 149 deletions(-)
>