[tarantool-patches] Re: [PATCH v2 07/11] sql: move sqlite3DeleteTrigger to sql.h
Kirill Shcherbatov
kshcherbatov at tarantool.org
Thu Jun 14 19:12:31 MSK 2018
On 13.06.2018 21:53, Vladislav Shpilevoy wrote:
> Thanks for the patch!
> Please, rationalize the patch in the commit message.
> I know why the patch is needed, but Nikita, for example,
> does not. Anyone else either.
sql: move sqlite3DeleteTrigger to sql.h
As we are going to port triggers to server, we need
an instrument to release allocated memory in alter.cc.
Part of #3273.
> Please, apply this:
- for (pElem = sqliteHashFirst(&temp2); pElem;
- pElem = sqliteHashNext(pElem)) {
- sql_trigger_delete(0, (Trigger *) sqliteHashData(pElem));
- }
+ for (pElem = sqliteHashFirst(&temp2); pElem != NULL;
+ pElem = sqliteHashNext(pElem))
+ sql_trigger_delete(NULL, (Trigger *) sqliteHashData(pElem));
- if (!pParse->pNewTrigger) {
+ if (pParse->pNewTrigger == NULL)
sql_trigger_delete(db, pTrigger);
- } else {
+ else
assert(pParse->pNewTrigger == pTrigger);
- }
More information about the Tarantool-patches
mailing list