[tarantool-patches] Re: [PATCH v2 3/3] sql: enable multi-engine tests for SQL

[n.pettik]

> 
> +-- SQL Analyze is working correctly only with memtx now.

But test-run anyway runs them twice:

[003] sql-tap/analyzeC.test.lua                       memtx           [ pass ]
[008] sql-tap/analyze7.test.lua                       memtx           [ pass ]
[002] sql-tap/analyze1.test.lua                       memtx           [ pass ]
[006] sql-tap/analyzeE.test.lua                       memtx           [ pass ]
[001] sql-tap/analyzeF.test.lua                       vinyl           [ pass ]
[007] sql-tap/analyze6.test.lua                       vinyl           [ pass ]
[006] sql-tap/analyzeC.test.lua                       vinyl           [ pass ]
[002] sql-tap/analyze8.test.lua                       memtx           [ pass ]
[006] sql-tap/analyze4.test.lua                       memtx           [ pass ]
[007] sql-tap/analyze4.test.lua                       vinyl           [ pass ]
[004] sql-tap/analyze3.test.lua                       memtx           [ pass ]
[006] sql-tap/analyzeD.test.lua                       memtx           [ pass ]
[007] sql-tap/analyze1.test.lua                       vinyl           [ pass ]
[004] sql-tap/analyze7.test.lua                       vinyl           [ pass ]
[003] sql-tap/analyzeD.test.lua                       vinyl           [ pass ]
[004] sql-tap/analyze6.test.lua                       memtx           [ pass ]
[003] sql-tap/analyzeF.test.lua                       memtx           [ pass ]
[006] sql-tap/analyze8.test.lua                       vinyl           [ pass ]
[002] sql-tap/analyzeE.test.lua                       vinyl           [ pass ]
[007] sql-tap/analyze5.test.lua                       memtx           [ pass ]
[004] sql-tap/analyze3.test.lua                       vinyl           [ pass ]
[001] sql-tap/analyze5.test.lua                       vinyl           [ pass ]
[005] sql-tap/analyze9.test.lua                       vinyl           [ pass ]
[008] sql-tap/analyze9.test.lua                       memtx           [ pass ]

Could we disable them for vinyl somehow and run only once?
Some of them take long time to execute.

> 
> diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini
> index e259be2..16aaf5a 100644
> --- a/test/sql-tap/suite.ini
> +++ b/test/sql-tap/suite.ini
> @@ -5,3 +5,4 @@ disabled =
> 	reindex.test.lua ; This test is banned in scope of #2174
> lua_libs = lua/sqltester.lua ../sql/lua/sql_tokenizer.lua ../box/lua/identifier.lua
> is_parallel = True
> +config = engine.cfg
> \ No newline at end of file

Lets put newline at the end of file.

> diff --git a/test/sql/engine.test.lua b/test/sql/engine.test.lua
> new file mode 100644
> index 0000000..2a07c71
> --- /dev/null
> +++ b/test/sql/engine.test.lua
> @@ -0,0 +1,17 @@
> +env = require('test_run')
> +test_run = env.new()
> +
> +box.sql.execute("pragma sql_default_engine='vinyl'")
> +box.sql.execute("CREATE TABLE t1_vinyl(a primary key,b,c);")
> +box.sql.execute("CREATE TABLE t2_vinyl(a primary key,b,c);”)

Please, use types for columns: we are going to introduce static types
in SQL and make them mandatory.