[tarantool-patches] Re: [PATCH v6 2/2] replication: force gc to clean xdir on ENOSPC err

Kirill Yukhin kyukhin at tarantool.org
Fri Jul 13 11:48:57 MSK 2018

On 12 июл 17:44, Konstantin Belyavskiy wrote:
> Garbage collector do not delete xlog unless replica do not notify
> master with newer vclock. This can lead to running out of disk
> space error and this is not right behaviour since it will stop the
> master.
> Fix it by forcing gc to clean xlogs for replica with highest lag.
> Add an error injection and a test.
> Changes in V2:
> - Promoting error from wal_thread to tx via cpipe.
> Changes in V3:
> - Delete consumers and only for replicas (but not backup).
> Changes in V4:
> - Bug fix and small changes according to review.
> Changes in V5:
> - Compare signatures of the oldest replica and the oldest snapshot
>   to keep to prevent deletion if it will not free any disk space.
> - Add say_crit on consumer deletion with a little information.
> Changes in V6:
> - Rebase to latest 1.10.
> - Update test.
Why did you put a ChangeLog entry to commit message?

Regards, Kirill Yukhin

More information about the Tarantool-patches mailing list