[tarantool-patches] Re: [PATCH] sql: assertion fail on nested select

[Alexander Turenko]

The patch LGTM. Nikita P., what do you think?

WBR, Alexander Turenko.

On Wed, Jul 18, 2018 at 06:37:00PM +0300, Nikita Tatunov wrote:
>    I woudln't consider it as an actual 'fix' though.
> 
>    ср, 18 июл. 2018 г. в 18:17, [1]n.pettik at corp.mail.ru
>    <[2]n.pettik at corp.mail.ru>:
> 
>    I tried to test that problem on this sqlite3 version with
>    -DSQLITE_DEBUG and assertion fails there.
>    Since flattening only makes another compound select-stmt with ORDER BY
>    clause I guess error was
>    occuring on flattened version of it. Moreover in latter versions of
>    sqlite3 this assert was deleted and the
>    restriction check wasn't fixed. So I assume sqlite3 developers just
>    don't know about it or don't aim on
>    fixing it as the error anyways occurs but on flattened subquery.
> 
>    Here is original fix of this assertion fail (JFYI):
>    [3]https://www.sqlite.org/src/info/823779d31eb09cda
> 
> References
> 
>    1. mailto:n.pettik at corp.mail.ru
>    2. mailto:n.pettik at corp.mail.ru
>    3. https://www.sqlite.org/src/info/823779d31eb09cda