[tarantool-patches] Re: [PATCH v1 1/1] box: support reload whole module

Vladimir Davydov vdavydov.dev at gmail.com
Wed Jul 11 15:59:53 MSK 2018


On Wed, Jul 11, 2018 at 03:52:46PM +0300, Kirill Shcherbatov wrote:
> On 11.07.2018 15:46, Vladimir Davydov wrote:
> > AFAIU a user may reload a whole module only if he has the global EXECUTE
> > privilege (because we don't have such an entity as module in our data
> > dictionary to grant access rights for). access_check_func(), which is
> > called by func_reload(), already checks the global EXECUTE privilege and
> > returns 0 (success) if it is set, no matter if the function was found or
> > not. So all you have to do is call module_reload() from func_reload() if
> > access_check_func() returned func = NULL, no?
> 
> No, this call iterates through all loaded functions of specified module and 
> reload all that belongs to initiator if any.

I understand what you code does, but I wonder why it does that.



More information about the Tarantool-patches mailing list