[tarantool-patches] Re: [PATCH v1 1/1] sql: refactor vdbe_emit_open_cursor calls

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Jul 10 18:56:24 MSK 2018

>> 2. Why vdbe_emit_open_cursor opens the cursor using index_id,
>> but opcode OP_OpenRead/Write still uses it as tnum?
> It is much more convenient to do this as a part of next commit.
> I temporary put this changes as a commit at head
> "sql: uniform OP_Open{Write,Read} ops to use tnum"

Maybe it is more convenient, but it is not more correct. Your
first commit still does not fix the mess with index_id/tnum.

Please, squash it into your first commit.

More information about the Tarantool-patches mailing list