[tarantool-patches] [PATCH 1/2] Test for valid syslog configuraton
vdavydov.dev at gmail.com
Tue Jul 17 17:10:32 MSK 2018
[ Please add an extra new line after a quote when replying to an email -
this improves readability ]
On Tue, Jul 17, 2018 at 05:07:32PM +0300, Olga Arkhangelskaia wrote:
> >Hmm, the test doesn't pass on certain distros (see travis). I guess,
> >this is because they don't have syslog configured. What about wrapping
> >box.cfg in pcall and checking the status? Since we just want to check
> >that there's no crash, this should do.
> I'll do that way.
> >Or alternatively you can test
> >this by setting a custom syslog destination (you have to test it anyway
> >in your other patches AFAIR).
> Do you mean in syslog destination series?
> I had a thought about it, but did not do in v2. Will keep in mind
Up to you.
More information about the Tarantool-patches