[tarantool-patches] Re: [PATCH] sql: remove support of partial indexes from parser

[Vladislav Shpilevoy]

Hello. Thanks for the patch! See 1 comment below.

On 02/07/2018 14:08, Nikita Pettik wrote:
> From: Gleb <gleb-skiba at mail.ru>
> 
> Currently, Tarantool doesn't support partial indexes, so lets temporary
> remove their processing from SQL parser to avoid confusing situations.
> It can be returned after #1260 (implement functional indexes in
> Tarantool) is done.
> 
> Closes #2165
> ---
> Branch: https://github.com/tarantool/tarantool/tree/gh-2165-remove-support-partial-indexes
> Issue: https://github.com/tarantool/tarantool/issues/2165
> 
>   src/box/sql/parse.y              |  4 ++--
>   test/sql-tap/analyze9.test.lua   |  2 +-
>   test/sql-tap/autoindex4.test.lua |  2 +-
>   test/sql-tap/fkey1.test.lua      |  2 +-
>   test/sql-tap/index6.test.lua     | 12 ++++++------
>   test/sql-tap/index7.test.lua     | 14 ++++++++------
>   6 files changed, 19 insertions(+), 17 deletions(-)
> 
> diff --git a/test/sql-tap/index7.test.lua b/test/sql-tap/index7.test.lua
> index c8f56eb29..11728d39e 100755
> --- a/test/sql-tap/index7.test.lua
> +++ b/test/sql-tap/index7.test.lua
> @@ -291,14 +291,16 @@ test:do_eqp_test(
>           -- </index7-6.4>
>       })
>   
> +-- gh-2165 Currently, Tarantool lacks support of partial indexes,
> +-- so temporary we removed processing of their syntax from parser.
> +--
>   test:do_catchsql_test(
> -    "index7-6.5",
> +    "index7-7.1",
>       [[
> -        CREATE INDEX t5a ON t5(a) WHERE a=#1;
> +        CREATE TABLE t1 (a INTEGER PRIMARY KEY, b INTEGER)
> +        CREATE UNIQUE INDEX i ON t1 (a) WHERE a = 3;
>       ]], {
> -        -- <index7-6.5>
> -        1, [[near "#1": syntax error]]
> -        -- </index7-6.5>
> +        1, "keyword \"CREATE\" is reserved"

1. The error is caused by typo in the request, not by lack of
partial indexes.

>       })
>   
>   test:finish_test()
> 

The rest is ok if the single purpose of the patch is to remove partial
indexes from frontend.