[tarantool-patches] Re: [PATCH v1 1/2] sql: get rid off sqlite3NestedParse in clean stats
v.shpilevoy at tarantool.org
Mon Jul 9 13:20:09 MSK 2018
Hello. Thanks for the fixes! I have force pushed my two-line minor
fix of a comment on the branch.
>> Also I have found that vdbe_emit_open_cursor() has the second
>> parameter named 'index_id', but in some places the function
>> takes real index_id, in other places it takes tnum, and in vdbe
>> it is interpreted as tnum. Please, fix this mess in a separate
>> commit. I think, we should always pass index_id.
> I've tried to do this and I'll append my diff to the end of this message,
> but there are some strange things..
> This should be investigated separately. I don't mind to do this, but I believe
> that this may delayed to be not a part of "remove sqlite3NestedParse function".
> Take a look at the end of this message.
Then fix this please on a separate branch. If it is easy, then it can be
done without an issue. If it takes more than 4 hours, then create an issue,
More information about the Tarantool-patches